Share 
Follow 
AboutDownloadsDocumentsForumsSource CodeIssuesNews
Date:
2019-05-16 21:31
Priority:
4
State:
Closed
Submitted by:
Joy Ku (joyku)
Assigned to:
Henry Kwong (hykwong2012)
Target Release:
4.1.0
Status:
Testing complete
Summary:
[data share] Notify user if malformed metadata file uploaded

Detailed description
I have to actively click the "Display Import Status" to realize that there is an error. Could an error dialog box pop up? Alternatively, can we just always display the status message and remove the "display import status" link? If there is an error, display the message as you currently have it. If there is no error, display "Files uploaded correctly" in green.

ISSUE: The indexing runs in the background. Not clear if there is a way for elfinder to know when the indexing has finished and to a make a call to the log file.

ALTERNATIVE SOLUTION: Perhaps when indexing is complete, an email could be sent to the user to indicate if there are errors or if everything has been uploaded correctly.

Add A Comment: Notepad

Message  ↓
Date: 2020-12-13 00:47
Sender: Joy Ku

Verified change

Date: 2020-12-13 00:07
Sender: Henry Kwong

- Updated the warning message.

Date: 2020-12-12 23:31
Sender: Joy Ku

There was typo in the earlier comment. Please move the period outside of the single quote: ...unknown term 'X'.

Date: 2020-12-12 23:16
Sender: Henry Kwong

- Updated warning message per feedback.

Date: 2020-12-12 22:35
Sender: Joy Ku

Updates confirmed. Please update message "Unknown term 'X' was used" to "Potential issue with unknown term 'X.'"

Date: 2020-12-11 01:02
Sender: Henry Kwong

- Updated notification of malformed metadata file upload per feedback.

Date: 2020-12-03 22:29
Sender: Joy Ku

Based on discussion, please change request (2) to throw a warning if the number of "value", number of "type", and number of parameters do not match. This condition would suggest that the metadata file is not formatted properly and would not behave as expected when querying.

Date: 2020-11-21 07:12
Sender: Joy Ku

Tested with json, yaml, and xml files. Errors caught and displayed if there was a syntax error, e.g., missing colon in yaml file.

Errors in naming conventions (e.g., "units" instead of "unit") were not caught. It would be helpful to add in checks for these. Specifically:

1) If the value for "type" is not "integer," "double," "text," "radio", "select," or "checkbox," throw an error.

2) Throw an error if "value" and "type" are not provided

3) Give a warning if anything other than "value," "type", or "unit" are listed for a parameter, e.g., Non-conventional term "X" was defined for the parameter A

Also, please update existing messages:

1) If error encountered, first state "Check metadata files." followed by error message. If possible, include folder name, e.g., "Check metadata file in folder X".

2) Instead of saying "No errors encountered during import." say "Import completed." We don't check for all possible errors, so we don't want to let user get that potentially false reassurance.

Date: 2020-08-10 21:22
Sender: Henry Kwong

- Updated handling of metadata import messages.
- Updated query-builder.
- Displayed validation error from query-builder if malformed metadata value is used in query rule.
- Re-enabled import status message.

Date: 2020-04-23 18:28
Sender: Joy Ku

To make this work properly will take a bit of work. For now please update the instructions to indicate that spaces are allowed. Also, remove display of Import Status. Change this task status back to "Accepted"

Date: 2020-04-18 22:20
Sender: Henry Kwong

- The indexer result from log file is updated in the elfinder Import Status display.
- The indexer should be updated to be more stringent in handling various error conditions.

Date: 2020-04-18 22:04
Sender: Joy Ku

1) Confirmed that import status is updated
2) However, basic errors are not being caught by the system. See examples below.
o No error appears when formatting is off, e.g., in the following:
overground_walking_speed:
type: double
unit: meters/seconds
value: 1.28
However, this parameter doesn’t show up in the query which seems to imply that there were issues with the indexing.
o If multiple values are assigned to a given parameter, indexer only registers first value assigned to parameter. No error message appears.
o When does parameter type matter? When I put in a mismatch between value and value type, no error appears. In some cases, the query still works and in some it doesn’t.

3) It seems like parameter names can have spaces. Please confirm if this is the case. If so, update instructions in https://simtkdata-stage-hk.stanford.edu/apps/import/metadata.php by removing text “Parameter names cannot have spaces and…”
4) Date-stamp
o Wrong date-stamp on import status. Import at 2:34 PM. Status message says 14:17:52.
o Add time zone to date- stamp

Date: 2020-04-01 18:57
Sender: Henry Kwong

- The Import Status is updated when the status message after an upload, either with "No errors encountered during import." or the error message.

Field Old Value Date By
status_idOpen2021-01-05 20:41hykwong2012
close_dateNone2021-01-05 20:41hykwong2012
StatusTesting2020-12-13 00:47joyku
StatusReady for testing2020-12-12 22:35joyku
StatusImplementing2020-12-11 01:02hykwong2012
StatusReady for testing2020-11-21 07:30hykwong2012
Target Release4.1.12020-08-10 21:22hykwong2012
StatusImplementing2020-08-10 21:22hykwong2012
Target Release4.0.52020-08-05 23:20hykwong2012
StatusAccepted2020-08-05 23:20hykwong2012
Target Release4.0.42020-06-26 21:40hykwong2012
Target Release4.0.32020-05-14 18:40hykwong2012
Target ReleaseNone2020-05-05 23:43hykwong2012
StatusImplementing2020-04-23 18:28joyku
StatusReady for testing2020-04-18 22:04joyku
StatusImplementing2020-04-01 18:57hykwong2012
StatusAccepted2020-02-20 21:47hykwong2012
assigned_tonone2020-02-20 19:56hykwong2012
StatusNone2020-02-20 19:56hykwong2012
Feedback