Share 
Follow 
AboutDownloadsDocumentsForumsSource CodeIssuesNews
Date:
2020-04-29 23:20
Priority:
4
State:
Closed
Submitted by:
Joy Ku (joyku)
Assigned to:
Henry Kwong (hykwong2012)
Target Release:
4.1.0
Status:
Testing complete
Summary:
[data share] Add license for DataShare feature

Detailed description
Similar to the project “Downloads” section, individuals should be shown a license and must agree to license before they are allowed to download from a study in Data Share.

For each study, the Admin panel should allow a selection of a license, similar to in the “Downloads” section.

That license should be displayed whenever a user tries to download from the study. Here are three known situations when the license should be shown and users must agree to license:
(1) “Browse” panel – when right-clicking on a file/folder and selecting “Download”
(2) “Browse” panel - when hitting the “Download Daily Archive” button
(3) “Query” panel – when hitting the “Get Data” button

Add A Comment: Notepad

Message  ↓
Date: 2020-11-18 21:11
Sender: Joy Ku

Confirmed update

Date: 2020-11-18 00:13
Sender: Henry Kwong

- Updated per feedback.

Date: 2020-11-18 00:06
Sender: Joy Ku

Confirmed updates. Please add period to sentence "Do not navigate away from this page until data retrieval is complete."

Date: 2020-11-16 23:29
Sender: Henry Kwong

- Updated formatting and UI per feedbacks.

Date: 2020-11-14 19:42
Sender: Joy Ku

Also verified that license information appears in history. In the "Download History" information, please add "none" for the license, instead of leaving it blank for downloads that occur when no license is to be agreed to.

Date: 2020-11-14 19:24
Sender: Joy Ku

Confirmed correct behavior in the following situations:

- Tested with “registered user” permission setting. License displayed correctly when a) downloading single file, b) downloading a small query result file, c) downloading a large query result file (already logged in and also if I am not logged in), d) downloading archived dataset
- Tested with “public user” permission setting. License displayed correctly when a) downloading single file, b) downloading a small query result file, c) downloading a large query result file, d) downloading archived dataset
- Tested with “public user” permission setting and “registered user” permission setting under 4 conditions above when no license is assigned by project administrator

Some formatting requests:
- Update message “Getting data….please wait. Do not navigate away from this page until download is complete” to “Getting data….please wait. Do not navigate away from this page until data retrieval is complete”
- On page that says “Please login if you have a SimTK account.”
o Change add space in header message so it says “Please log in….” Remove period.
o Change “Skip” to “I do not have an account” or if that is too long, use “No account”
o Change “Login” to “Log in”

- Before going to license page, sometimes screen displays an empty query window + download frame

- Content is not left-aligned with header that says "Data Share." Please align.


Date: 2020-11-03 23:03
Sender: Henry Kwong

- Updated tooltip in license configuration.
- Updated handling for large query results download.
- Updated archive, file, and query results download UI.
- Added download progress display.

Date: 2020-10-27 00:05
Sender: Joy Ku

The large package download problem was a user error. My pop-ups were blocked. The email mentioned unblocking pop-ups. It would be helpful to link that action directly to the download problem.

Date: 2020-10-26 22:52
Sender: Joy Ku

Also, for large packages, there are some issues:

1) When I click on the email and am not already logged in to SimTK, I get taken to the general Data Study page. It is not clear where to go from there.

2) If I am already logged in to SimTK, I should be taken to the blank page described in (4) in the comment from earlier today.

3) The message for the "Download" message appears but no package is ever downloaded. This was in the case where no license was selected. I did not test if this worked if a license was selected.

Date: 2020-10-26 22:25
Sender: Joy Ku


1. License display appears for the three listed cases.
2. Need to update tool tip for License Agreement: Replace first paragraph
"You can display a download agreement to users before they download any file in this package. The option to show this agreement can be removed for a given file when that file is added to the package." to "You can display a download agreement to users before they download any file in this study."
3. Change button “Browse Data” on all license-related pages to “Return to Study Data”
4. After user selects “I Agree & Download Now,” take user to a blank page with the message “Downloading file… Please wait.” When file download is complete, a new message should appear (or overwrite) the existing message and say “Download completed.”
5. If no license is chosen, user should be taken to blank page with the behavior as described in (4) above

Date: 2020-07-20 23:59
Sender: Henry Kwong

- Added support for license configuration and display of license agreement for:
(1) Browse panel file download.
(2) Browse panel "Download Daily Archive"
(3) Query panel "Get Data".

Field Old Value Date By
status_idOpen2021-01-05 20:41hykwong2012
close_dateNone2021-01-05 20:41hykwong2012
StatusReady for testing2020-11-18 21:11joyku
StatusImplementing2020-11-16 23:29hykwong2012
StatusReady for testing2020-11-14 20:11hykwong2012
StatusImplementing2020-11-03 23:03hykwong2012
assigned_tojoyku2020-10-26 22:53hykwong2012
StatusTesting2020-10-26 22:53hykwong2012
assigned_toboogers2020-10-24 00:46joyku
StatusReady for testing2020-10-24 00:46joyku
assigned_tohykwong20122020-10-09 21:30joyku
Target Release4.0.52020-07-20 23:59hykwong2012
StatusAccepted2020-07-20 23:59hykwong2012
Target Release4.0.42020-06-26 21:39hykwong2012
Target Release4.0.32020-05-07 18:52joyku
Target ReleaseNone2020-05-05 23:44hykwong2012
StatusNone2020-04-29 23:55hykwong2012
Feedback